Thanks Mei. Please go ahead with your check-in.
Michael
From: Ye, Mei
Sent: Wednesday, February 01, 2012 11:37 AM
To: Lai, Michael; 'open64-devel@lists.sourceforge.net'
Subject: RE: [Open64-devel] code review (WOPT)
Michael and Sun,
Thanks for your comments. With regard to (2), I made an attempt to separate
proactive-opt out, please refer to a driver routine "Proactive_Optimizer" in
"opt_main.cxx".
Proactive-opt is based on CFG, so LNO is not a good place for it.
"Proactive_Optimizer" was meant to build CFG and call proactive-opt. However,
doing so causes performance degradation since WOPT nicely cleans up codes after
the proactive-opt. WOPT is also desired to be run before proactive-opt.
Currently, the phase-ordering is: WOPT->LNO1->LNO, where "LNO1" is
proactive-opt plus some WOPT components. Also, I have removed "ifdef".
This patch does not need much assertions.
-Mei
From: Lai, Michael
Sent: Wednesday, February 01, 2012 1:18 AM
To: Ye, Mei; 'open64-devel@lists.sourceforge.net'
Subject: RE: [Open64-devel] code review (WOPT)
Mei, I read through your changes, and did not see any blocking issues.
However, here are some minor comments from Sun Chan and me, for your future
consideration:
1. You may want to add more assertions.
2. I see that you already did some minor reorganization of your code; in
the future you may want to do more reorganization with respect to what should
be in WOPT and what can be moved out of WOPT.
3. There are some obsolete #ifdef's that can be removed (in wn.cxx).
Thanks,
Michael Lai
From: Ye, Mei [mailto:mei...@amd.com]<mailto:[mailto:mei...@amd.com]>
Sent: Thursday, January 26, 2012 3:33 PM
To: 'open64-devel@lists.sourceforge.net'
Subject: [Open64-devel] code review (WOPT)
Attached patch is an enhancement of proactive loop opt. It allows tail
duplication of SC_Ifs to enable more if-merging., and allows
extended-proactive-loop-opt phase to remove more redundant bit-operations and
empty if-regions. Also does some minor reorg for code sharing.
-Mei
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Open64-devel mailing list
Open64-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/open64-devel
