Actually, since the diagnostic msg output touches about every other line in the routine, it's kindof pointless not to reindent at the same time. (Not re-indenting that subroutine when I did the changes would shrink the size of the diff by maybe 10-15% at most.)
Yes, I'd prefer that the reindenting be done projectwide independently, but if a patch is going to be submitted that changed so much of a subroutine, it really is pointless to delay unless someone objects to the different formatting. -- Nathan ------------------------------------------------------------ Nathan Neulinger EMail: [EMAIL PROTECTED] University of Missouri - Rolla Phone: (573) 341-4841 Computing Services Fax: (573) 341-4216 > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, February 06, 2002 12:37 PM > To: [EMAIL PROTECTED]; [EMAIL PROTECTED] > Subject: Re: [OpenAFS-devel] Patch to add much more > diagnostics to vos move when run with -verbose > > > Actually, what worries me about the patch is how many gratuitous diffs > it contains, presumably "cleaning up" indentation, spacing, and the > like. While the short-term results may look OK, it means > that all kinds > of patches down the line will keep seeing these gratuitous > differences. > Worse, if someone "cleans up" in some other way, still more gratuitous > differences will abound, obfuscating real (functional) changes. > > The OpenAFS code may not be beautiful, but efforts to re-indent and so > forth need to be coordinated a lot better than this to > circumvent merge > grief in the future. > > Regards, > Craig > > _______________________________________________ > OpenAFS-devel mailing list > [EMAIL PROTECTED] > https://lists.openafs.org/mailman/listinfo/openafs-devel > _______________________________________________ OpenAFS-devel mailing list [EMAIL PROTECTED] https://lists.openafs.org/mailman/listinfo/openafs-devel
