On Jan 2, 2007, at 11:32 AM, Jim Rees wrote:
I would rather you decreased the number of ifdefs in afs_osi.c. As a
general rule I would like to see the systype-dependent code
confined to the
various afs/FOO/ subdirs. What I did with OpenBSD was move
afs_osi_suser
out of afs_osi.c (it's ifdefed out) and into OBSD/.
But please keep up the good work. We need people working on Solaris.
Hmm, okay, if that's your suggestion. My coding idiosyncrasy is to be
leery having multiple definitions for the same function sprinkled
around the code tree. I was just operating under the assumption that
all afs_* functions were defined, along with any OS-specifics, in src/
afs/ and the bits to tie those funcs into different OSs' VFS layers
resided in the appropriate OS sub directory.
You know, so if you're hunting down a common bug in some random afs_*
function you don't have to rummage through however many OS sub dirs,
finding and fixing each specific implementation. I'd rather go to one
file, and see it all there, ifdefs and all.
But if you say so.... :)
/dale
--
Dale Ghent
UNIX Systems Specialist
UMBC - Office of Information Technology
ECS 201 - x51705
_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel
