"I would prefer that you didn't submit this" seems iffy also, as -1 could as easily mean, resubmit this. I.e., it's easy to interpret 'this' as the idea underlying some submission, not the changeset.
Matt ----- "Jeffrey Altman" <[email protected]> wrote: > Simon Wilkinson wrote: > > To summarise, they are: > > > > Code review: > > +2: Looks good to me, approved > > +1: Looks good to me, but someone else must approve > > 0: No score > > -1: I would prefer that you didn't submit this > > -2: Do not submit > > Several people have felt uncomfortable with the language of +1. > How about just changing it to "Looks good to me". > > Jeffrey Altman > > > _______________________________________________ > OpenAFS-devel mailing list > [email protected] > https://lists.openafs.org/mailman/listinfo/openafs-devel -- Matt Benjamin The Linux Box 206 South Fifth Ave. Suite 150 Ann Arbor, MI 48104 http://linuxbox.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309 _______________________________________________ OpenAFS-devel mailing list [email protected] https://lists.openafs.org/mailman/listinfo/openafs-devel
