Jeffrey Altman <[email protected]> writes:
>> -1: I would prefer that you didn't submit this
>> -2: Do not submit
>
> Several people have felt uncomfortable with the language of +1.
> How about just changing it to "Looks good to me".

While we're at it, I think there's some ambiguity in the word "submit"
in the -1/-2 -- my first reaction was "but I already submitted it to
gerrit!  It's too late!"

Maybe "I would prefer that this not be merged".

  - a

_______________________________________________
OpenAFS-devel mailing list
[email protected]
https://lists.openafs.org/mailman/listinfo/openafs-devel

Reply via email to