On Tue, Oct 6, 2009 at 8:29 AM, Gerrit Code Review <[email protected]> wrote: > The following commit has been merged in the master branch: > commit e5cf14ba043f29b8b81440e6c32cf6f1cc91851c > Author: Hartmut Reuter <[email protected]> > Date: Tue Oct 6 09:10:45 2009 +0200 > > New option '-cmd' for 'fs listacl' > > prints 'fs setacl' commands necessary to create the current > ACLs. This is useful for backup scripts using TSM (or others) > to save the ACLs into a file to allow for later restore. > > Reviewed-on: http://gerrit.openafs.org/556 > Reviewed-by: Derrick Brashear <[email protected]> > Tested-by: Derrick Brashear <[email protected]> > > src/venus/fs.c | 86 ++++++++++++++++++++++++++++++++++--------------------- > 1 files changed, 53 insertions(+), 33 deletions(-) > > --
Is there a man page update for this change or any tests/examples for the new interface? I don't see either in this commit, but there is a comment that an RT ticket can be opened up to request the documentation. Wouldn't it be better to require documentation updates for all patches that change command interfaces? There would be much, much less documentation-drift that way. As for tests, well, tests are appreciated. I started to update gerrit with this query; however, as this seems a larger question, so I thought it more appropriate to discuss here. Thanks, Steven _______________________________________________ OpenAFS-devel mailing list [email protected] https://lists.openafs.org/mailman/listinfo/openafs-devel
