Steven Jenkins wrote: > On Tue, Oct 6, 2009 at 8:29 AM, Gerrit Code Review <[email protected]> wrote: >> The following commit has been merged in the master branch: >> commit e5cf14ba043f29b8b81440e6c32cf6f1cc91851c >> Author: Hartmut Reuter <[email protected]> >> Date: Tue Oct 6 09:10:45 2009 +0200 >> >> New option '-cmd' for 'fs listacl' >> >> prints 'fs setacl' commands necessary to create the current >> ACLs. This is useful for backup scripts using TSM (or others) >> to save the ACLs into a file to allow for later restore. >> >> Reviewed-on: http://gerrit.openafs.org/556 >> Reviewed-by: Derrick Brashear <[email protected]> >> Tested-by: Derrick Brashear <[email protected]> >> >> src/venus/fs.c | 86 >> ++++++++++++++++++++++++++++++++++--------------------- >> 1 files changed, 53 insertions(+), 33 deletions(-) >> >> -- > > Is there a man page update for this change or any tests/examples for > the new interface? I don't see either in this commit, but there is a > comment that an RT ticket can be opened up to request the > documentation.
http://gerrit.openafs.org/586 http://rt.central.org/rt/Ticket/Display.html?Action=Take&id=125470 > Wouldn't it be better to require documentation updates for all patches > that change command interfaces? There would be much, much less > documentation-drift that way. In general we would like to see documentation updates for all commits. However, we are far from the point where we can demand that we either obtain a documentation or will refuse to accept code when a contribution has been requested from a developer. > As for tests, well, tests are appreciated. Tests are certainly appreciated but again we do not require them for minor contributions such as this. Please review the pending gerrit patch. A ticket was created in the openafs-docs RT a well since most of the documentation contributors are not hard core developers and have not created accounts in gerrit. Jeffrey Altman
smime.p7s
Description: S/MIME Cryptographic Signature
