On 7/26/2010 12:39 PM, Jason Edgecombe wrote: > Hi everyone, > > I want some input on how to approve patches for building with buildbot. > I see the following options: > > 1. Make a category in Gerrit and give certain people the ability to set > this category.
Too much manual effort. > 2. Automatically build patches sent from an approved list of people and > additionally build anything with a +1 from that same list. This is desirable. The goal is to reduce the manual effort required by those with bits. By having the majority of submissions (those from trusted submitters) be automatically built, we can avoid reviewing patches that fail. > Option one is supported by the buildbot gerrit code and allows for > multiple people to manage the group of build-blessers. > Option two requires some custom code and it would likely fall on one > person to manage that hard-coded list. Additionally, option two would be > overloading the meaning of the "+1 approve" category. The point of having someone from the trusted list approve of an untrusted submission before having it be built is to make sure that the submission is (a) not dangerous; and (b) worth the effort to build. We assume that any patch submission from a trusted submitter is build worthy. Thanks for your efforts. Jeffrey Altman
smime.p7s
Description: S/MIME Cryptographic Signature
