On 10 Feb 2012, at 04:29, Jeffrey Altman wrote: > That field was commented out before OpenAFS and maxPacketSize was not > referenced anywhere in the source code. What restoring that field to > rx.h does is force the struct rxevent * values that follow it to become > properly aligned in 64-bit builds. > > Lack of proper alignment can really hurt.
I'm a little confused here. The System V ABI, which Linux claims to follow, specifies that pointers are 8 byte aligned - see Figure 3.1 of http://www.x86-64.org/documentation/abi.pdf Given that your speed improvements are from vos release, this must be userspace code, so I'm not certain that this is an alignment issue. Cheers, Simon. _______________________________________________ OpenAFS-info mailing list [email protected] https://lists.openafs.org/mailman/listinfo/openafs-info
