Hi,

 

We use openais-0.70. I was looking at the function saServiceConnect()
since there was a fd leak when the EvtInitialize failed - this appears
to be resolved in the later versions, I have back ported the change.
However while looking through the code - I had a question regarding the
following code snippet right at the bottom of the function ...

 

/*

 * Check for security errors

 */

if(res_lib_dispatch_init.header.error != SA_AIS_OK) {

            error = res_lib_dispatch_init.header.error;

            goto error_exit;

}

 

*callbackOut = callbackFD;

 

My question is ... the goto within the 'if' should it be 'goto
error_exit_two' - should the callbackFD be closed as well?! 

 

Best Regards.

Amar.

_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais

Reply via email to