Hi Steve, Thank you for the quick response. We will seriously consider moving to Whitetank in our next release. I already ported the changes for the fd leak to 0.70 in our local repository. I was wondering if the code-snippet below was anything to be concerned about?! I believe it is the same in 0.80.3 as well.
Regards. Amar. -----Original Message----- From: Steven Dake [mailto:[EMAIL PROTECTED] Sent: Monday, June 09, 2008 7:42 PM To: Amarnath Sathyanarayanan Cc: [EMAIL PROTECTED] Subject: Re: [Openais] saServiceConnect bug?! Amar, I will produce a patch for your problem below. I _highly_ recommend using the stable version of openais which is known as the whitetank branch. It has undergone many thousands of hours of testing and bug fixing efforts by the community and various companies on top of 0.70 and is really rock solid. It is deployed in virtually every distribution and has rock solid reliability compared to version 0.70. There is only one remaining issue in openais 0.80.3 relating to checkpoints that is known through all of the testing and qualification the software has undergone. The protocol specifically in 0.70.x is not very stable and has serious defects in many major components and I can't recommend using it in deployment. If you can make the move, again, I'd highly recommend it. Regards -steve On Mon, 2008-06-09 at 13:53 -0400, Amarnath Sathyanarayanan wrote: > Hi, > > > > We use openais-0.70. I was looking at the function saServiceConnect() > since there was a fd leak when the EvtInitialize failed - this appears > to be resolved in the later versions, I have back ported the change. > However while looking through the code - I had a question regarding > the following code snippet right at the bottom of the function ... > > > > /* > > * Check for security errors > > */ > > if(res_lib_dispatch_init.header.error != SA_AIS_OK) { > > error = res_lib_dispatch_init.header.error; > > goto error_exit; > > } > > > > *callbackOut = callbackFD; > > > > My question is ... the goto within the 'if' should it be 'goto > error_exit_two' - should the callbackFD be closed as well?! > > > > Best Regards. > > Amar. > > > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
