Honza, Please merge this patch into your patch. It allows make distcheck to work properly.
Regards -steve On Sat, 2009-11-28 at 14:24 -0700, Steven Dake wrote: > Honza, > > Few comments on code: > > please use poll instead of select > > poll/select syscalls can return -1 errno = EINTR which should be handled > by a goto to retry the poll operation. > > read/write syscalls can return EAGAIN/EINTR in which case they should be > retried > > changed "readed" to "bytes_read" > > the return error for waitpid is not checked > > instead of return (unused_param) use return (NULL) > > change reincarnation_id to "generation_id" > > Other then those nitpicks, looks like a really clever design, simple to > use, and effective at solving the problem outlined. > > I'll edit the lib documentation and send you a patch. Once that is done > and the above is resolved we can take another stab at review/merge. > > Great work > > Regards > -steve > > On Fri, 2009-11-20 at 12:34 +0100, Jan Friesse wrote: > > Attached is first public SAM version for review. If you are unsure, what > > SAM is, please look to corosync roadmap > > ftp://ftp%40corosync%2Eorg:[email protected]/presentations/corosync-roadmap.pdf > > > > What really needs to be done is documentation (next week action), but > > code and API should be stable. > > > > I hope you will enjoy it. > > > > Regards, > > Honza > > _______________________________________________ > > Openais mailing list > > [email protected] > > https://lists.linux-foundation.org/mailman/listinfo/openais > > _______________________________________________ > Openais mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/openais
Index: include/Makefile.am =================================================================== --- include/Makefile.am (revision 2542) +++ include/Makefile.am (working copy) @@ -32,7 +32,8 @@ MAINTAINERCLEANFILES = Makefile.in corosync/config.h.in CS_H = hdb.h cs_config.h cpg.h cfg.h evs.h mar_gen.h swab.h \ - coroipcc.h coroipcs.h coroipc_types.h corodefs.h confdb.h list.h corotypes.h quorum.h votequorum.h + coroipcc.h coroipcs.h coroipc_types.h corodefs.h \ + confdb.h list.h corotypes.h quorum.h votequorum.h sam.h CS_INTERNAL_H = ipc_cfg.h ipc_confdb.h ipc_cpg.h ipc_evs.h ipc_pload.h ipc_quorum.h \ jhash.h pload.h cs_queue.h quorum.h sq.h ipc_votequorum.h coroipc_ipc.h
_______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
