Steve,
>
> please use poll instead of select
- Used now
>
> poll/select syscalls can return -1 errno = EINTR which should be handled
> by a goto to retry the poll operation.
- Was there but maybe not so much explicit
>
> read/write syscalls can return EAGAIN/EINTR in which case they should be
> retried
- Fixed
>
> changed "readed" to "bytes_read"
- Fixed
>
> the return error for waitpid is not checked
- Not fixed, but will be tomorrow (this is why patch not included).
>
> instead of return (unused_param) use return (NULL)
- This (ugly) thing is there for make compiler happy. I added comment,
so everyone should understand it now (I'm not sure how to make compiler
happy different way)
>
> change reincarnation_id to "generation_id"
Don't agree. I will explain you why. Generation looks like:
GrandGrandParent -> GrandParent -> Parent -> Child
But what we are doing is:
Parent -> First child (die)
-> Second child (die)
-> Third child (die)
-> ...
So I changed this to instance_id.
Regards,
Honza
_______________________________________________
Openais mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/openais
