On 06/12/2010 09:29 PM, Steven Dake wrote: > Andreas, > > Thanks for all the work on this, but your intuition of removing the code > completely (your first patch) is correct. This is why the patch was > applied without argument. I don't want ifdef's in the code around debug > output. Libraries in general, such as logsys, should never print any > type of output (unless that is their purpose in the case of stderr mode > of operation). If a field deployment can't turn optional code with a > runtime (vs build time) configuration option, then it doesn't belong in > the codebase. > > In some cases we make exceptions but they are rare and this type of > debug output doesn't warrant one of those exceptions.
Then make sure to keep a copy of the patch around for your own sake. As I already explained to you, the patch debugs a very specific problem in logsys init code that is dependent on gcc behaviour (compiler and linker). You really don't want to waste heaps of time re-writing it again. Fabio _______________________________________________ Openais mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/openais
