On Oct 30, 2010, at 11:27 AM, Michael Banck wrote:

> inchi?  I patched the inchi CMakeLists.txt to force STATIC for the
> Debian/Ubuntu builds.

Could you submit this as a patch to the feature or patch tracker?

> should be static.  How much disk space is wasted by linking in a [dynamic]
> inchi for the format and desriptor (what else?)

It's integrated into a few of the ops, such as sort and unique. IMHO, the best 
solution is if there's a more official InChI package release. At one point, I 
offered to do that (since we do 80% of the work for Open Babel) but never heard 
any interest from the InChI trust.

Maybe it's worth inquiring again.

> Similarly, installing inchi_api.h to /usr/include/inchi seems like a
> namespace violation to me, is that header file really needed from the

That's a big mistake, sorry. I admit I didn't check the CMake files for 
includes. inchi_api.h should go under openbabel/

Thanks for pointing out these issues.
-Geoff
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store 
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

Reply via email to