On Sun, Oct 31, 2010 at 10:30:34PM -0400, Geoffrey Hutchison wrote:
> On Oct 30, 2010, at 11:27 AM, Michael Banck wrote:
>
> > inchi? I patched the inchi CMakeLists.txt to force STATIC for the
> > Debian/Ubuntu builds.
>
> Could you submit this as a patch to the feature or patch tracker?
Well, it was just a crude hack to replace the ${BUILD} variable with an
unconditional STATIC. Tim's change to have a CMake variable looks much
nicer to me, except it only does things for totally static builds.
The big problem we still have is that if you set inchi to STATIC, the
inchi source files will get compiled without -fPIC, and later linking
inchiformat.o will fail on some architectures, like:
| /usr/bin/ld: inchi103/libinchi.a(ikey_dll.o): relocation R_X86_64_32
| against `.rodata.str1.1' can not be used when making a shared object;
| recompile with -fPIC
| inchi103/libinchi.a: could not read symbols: Bad value
Does anybody know how to elegantly tell CMake to compile a static
libinchi but with -fPIC?
> > should be static. How much disk space is wasted by linking in a [dynamic]
> > inchi for the format and desriptor (what else?)
>
> It's integrated into a few of the ops, such as sort and unique. IMHO,
> the best solution is if there's a more official InChI package release.
> At one point, I offered to do that (since we do 80% of the work for
> Open Babel) but never heard any interest from the InChI trust.
>
> Maybe it's worth inquiring again.
Yes, this would be best, but is more of a mid-term solution. Just
releasing a patch-set against the official inchi103 release which helps
compilation on Unix might be a first step.
The big problem will be to work with upstream on library versioning (if
we care at all), right now they just encode their upstream version like
libinchi.so.1.0.3 I think.
Michael
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel
