Thanks all for their feedback. I have committed a fix as per Dr. O'Boyle's suggestion as well as preliminary support for periodicity in the MOPAC reader (a new feature in MOPAC 2007 and 2009).
Thanks, · Jiahao Chen · MIT Chemistry · On Mon, Jul 4, 2011 at 12:48, Geoffrey Hutchison <ge...@geoffhutchison.net> wrote: >> Would an easier fix be to simply replace > > I agree with Noel's suggestion. > >>> I have a patch that will fix this behavior sufficiently for my >>> purposes. I would like to commit this upstream, but I thought I would >>> ask first since this would modify a core utility function and could >>> very well break code that expects this behavior. > > Well, the idea is to introduce it to trunk, check if "make test" still passes > everything, and then we wait to see if it introduces bugs (e.g., in other > formats). > > My guess is "no" since code written to use tokenize anticipates that all > tokens on the line would be parsed. > > -Geoff > > ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ OpenBabel-Devel mailing list OpenBabel-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-devel
