Hi Paul, Sounds great.
It'd be definitely nice to have some test cases to ensure that it actually works as intended and will keep working. It's sound like you have some already. I can help integrate these if you wish. There is also information over at https://open-babel.readthedocs.io/en/latest/Contributing/Testing.html The usual way to submit code is via Github - this also helps us keep track of things. Are you happy to send a pull request via that route? Regarding release forms, I don't think that's something we can help with. We don't require it. That is, it's between you and your employer whether you have permission to give us this code under the GPL. Regards, - Noel On Wed, 20 Feb 2019 at 18:07, Paul Becherer <paul.beche...@culgi.com> wrote: > Dear all, > > At the software company that I work for (Culgi B.V., Leiden, The > Netherlands, https://www.culgi.com/), we have been using Open Babel for > a while now, for conversion between our file format and other formats. To > get this working, we have added a file format to the Open Babel source, and > we currently build a 'custom' executable with this extra file. > > To comply with the GNU GPL we do not link our proprietary software to Open > Babel, but just run the executable using input and output files, and we've > always made the modified Open Babel source available to our users under the > GPL. > > Of course in the long run it would be easier for us, and for our users, to > have this file format support integrated into the regular Open Babel > distribution. We'd like to contribute the code that we use for that. I have > attached a patch that should work against the latest source from GitHub. > > As it will be primarily our customers and ourselves who will benefit from > this (at least at this time) we're willing to assume responsibility for > maintaining this code for the foreseeable future. > > We could not really find hard guidelines for coding standards, or what > kinds of tests are desired, so I'd appreciate any feedback on that. The > code in the patch is based on the exampleformat.cpp template and was > further developed by two colleagues and myself at Culgi. We presently test > conversion to and from the MOL and MOL2 formats in our own test suite. > > I can imagine that some kind of release form or other document from my > employer is required before the code can be integrated into the regular > Open Babel source. I'd be very grateful if anyone could guide us through > any formalities here. > > > Kind regards, > > Paul Becherer > > Development Scientist > > Culgi B.V. > Galileiweg 8 > 2333 BD Leiden > The Netherlands > > Phone: + 31 71 33 22 056 > www.culgi.com > > > > _______________________________________________ > OpenBabel-discuss mailing list > OpenBabel-discuss@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openbabel-discuss >
_______________________________________________ OpenBabel-discuss mailing list OpenBabel-discuss@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbabel-discuss
