Pull request with fixes sound good, as long as functionality stays the same or is improved.
I don't use Lucee/Railo or ACF, so I don't test on those engines, but if others are willing to make compatability changes that's great. Marcus On Friday, July 17, 2015 at 4:31:32 AM UTC-4, Harry Klein wrote: > > Hi Marcus, > > > > thanks, I just tested your tool with Lucee and (after changing all > console() calls to writelog()) it seems to run also on this engine. > > I found some issues, but would have to investigate if these are problems > with Lucee or with the application itself. > > e.g. the test for unusedVars did run really long in a bigger CFC and was > hanging here: > > > > java.lang.Throwable.getStackTraceElement(Throwable.java:???)[Native > Method] > java.lang.Throwable.getOurStackTrace(Throwable.java:826) > - locked <0x1683ccab> (a java.lang.Exception) > java.lang.Throwable.getStackTrace(Throwable.java:815) > java.lang.Thread.getStackTrace(Thread.java:1567) > lucee.commons.io.SystemUtil.getCurrentContext(SystemUtil.java:910) > lucee.runtime.debug.DebuggerImpl.addImplicitAccess(DebuggerImpl.java:753) > lucee.runtime.type.scope.UndefinedImpl.debugCascadedAccess( > UndefinedImpl.java:241) > lucee.runtime.type.scope.UndefinedImpl.debugCascadedAccess( > UndefinedImpl.java:237) > lucee.runtime.type.scope.UndefinedImpl.getCollection(UndefinedImpl.java: > 383) > mscan_master270.tests.unusedvars_cfc$cf.udfCall( > D:\projekte_cf\mScan-master\tests\unusedVars.cfc:43) > > > > Not sure if you want me to create a pull request with my Lucee > compatibility changes? But in my opinion it would be a shame if this tool > would only support OpenBluedragon only because of the miossing console > Method in other engines. > > > > -Harry > > > > *Von:* [email protected] <javascript:> [mailto: > [email protected] <javascript:>] *Im Auftrag von *Marcus F > *Gesendet:* Freitag, 17. Juli 2015 03:59 > *An:* [email protected] <javascript:> > *Betreff:* [OpenBD] New and shiny: Open source code quality scanner > > > > Long story short, I created a code quality testing engine and it's > available on GitHub. > > The tests are mostly based on coding standards from work, but not entirely > or completely, I'd be happy to create more tests or add ones created by > others. > > It's super easy to add new tests, just create a new cfc in the tests > directory, following the standard in the other tests, and it'll be > available automatically. (There's no need to register new tests) > > If you're running locally on a Windows machine, you should be able to > click the name of a file and have it open with the OS default software. > > This is the first release, I'm sure there are some bugs and odd behaviour, > and I happily accept bug reports and whatnot in this thread. > > > https://github.com/MFernstrom/mScan > > -- > -- > online documentation: http://openbd.org/manual/ > http://groups.google.com/group/openbd?hl=en > > --- > You received this message because you are subscribed to the Google Groups > "Open BlueDragon" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > For more options, visit https://groups.google.com/d/optout. > -- -- online documentation: http://openbd.org/manual/ http://groups.google.com/group/openbd?hl=en --- You received this message because you are subscribed to the Google Groups "Open BlueDragon" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
