details:   /erp/devel/pi/rev/02f4b39d20c1
changeset: 11938:02f4b39d20c1
user:      Martin Taal <martin.taal <at> openbravo.com>
date:      Wed May 04 16:49:08 2011 +0200
summary:   Related to issue 16872: Open in new tab: performance improvement

diffstat:

 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
 |  2 +-
 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
     |  5 +++++
 2 files changed, 6 insertions(+), 1 deletions(-)

diffs (27 lines):

diff -r ed2986ece0ef -r 02f4b39d20c1 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
      Wed May 04 15:26:47 2011 +0200
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
      Wed May 04 16:49:08 2011 +0200
@@ -1042,7 +1042,7 @@
     // is actually a different parent selected, only then refresh children
     var differentRecordId = !this.lastRecordSelected || 
!this.viewGrid.getSelectedRecord() ||
       this.viewGrid.getSelectedRecord().id !== this.lastRecordSelected.id;
-    var selectedRecordId = this.viewGrid.getSelectedRecord().id;
+    var selectedRecordId = this.viewGrid.getSelectedRecord() ? 
this.viewGrid.getSelectedRecord().id : null;
     
     this.updateLastSelectedState();
     this.updateTabTitle();    
diff -r ed2986ece0ef -r 02f4b39d20c1 
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
--- 
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
  Wed May 04 15:26:47 2011 +0200
+++ 
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
  Wed May 04 16:49:08 2011 +0200
@@ -517,6 +517,11 @@
       this.selectionUpdated();
     }
     
+    // no data and the grid is not visible
+    if (endRow === 0 && !this.isVisible()) {
+      this.show();
+    }
+    
     if (this.targetOpenNewEdit) {
       delete this.targetOpenNewEdit;
       // not passing record opens new

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits

Reply via email to