details: /erp/devel/pi/rev/211cf49219b3
changeset: 11939:211cf49219b3
user: Martin Taal <martin.taal <at> openbravo.com>
date: Wed May 04 17:01:59 2011 +0200
summary: Related to issue 16872: Open in new tab: performance improvement
diffstat:
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
| 2 +-
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
| 8 ++++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diffs (37 lines):
diff -r 02f4b39d20c1 -r 211cf49219b3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
Wed May 04 16:49:08 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-standard-view.js
Wed May 04 17:01:59 2011 +0200
@@ -714,7 +714,7 @@
if (this.shouldOpenDefaultEditMode()) {
this.openDefaultEditView();
- } else if (this.isShowingForm) {
+ } else if (this.isShowingForm && !(this.allowDefaultEditMode &&
this.defaultEditMode)) {
this.switchFormGridVisibility();
}
this.viewGrid.refreshContents();
diff -r 02f4b39d20c1 -r 211cf49219b3
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
---
a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
Wed May 04 16:49:08 2011 +0200
+++
b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-view-grid.js
Wed May 04 17:01:59 2011 +0200
@@ -519,7 +519,11 @@
// no data and the grid is not visible
if (endRow === 0 && !this.isVisible()) {
- this.show();
+ if (this.view.isShowingForm) {
+ this.view.switchFormGridVisibility();
+ } else {
+ this.show();
+ }
}
if (this.targetOpenNewEdit) {
@@ -534,7 +538,7 @@
} else if (this.targetRecordId) {
// direct link from other tab to a specific record
this.delayedHandleTargetRecord(startRow, endRow);
- } else if (this.view.shouldOpenDefaultEditMode() &&
!this.view.isShowingForm) {
+ } else if (this.view.shouldOpenDefaultEditMode()) {
// ui-pattern: single record/edit mode
this.view.openDefaultEditView(this.getRecord(startRow));
} else if (this.data && this.data.getLength() === 1) {
------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network
management toolset available today. Delivers lowest initial
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
