details: https://code.openbravo.com/erp/devel/pi/rev/d61db4a5e84b changeset: 13580:d61db4a5e84b user: Adrián Romero <adrianromero <at> openbravo.com> date: Thu Aug 18 13:04:35 2011 +0200 summary: Fixes issue 0016765: Selector in manual window: not possible to remove the selected value and fire onchange event Now the event callout is fired in every change of the selector
details: https://code.openbravo.com/erp/devel/pi/rev/ff6655a3b321 changeset: 13581:ff6655a3b321 user: Adrián Romero <adrianromero <at> openbravo.com> date: Thu Aug 18 13:05:42 2011 +0200 summary: Fixes issue 0018056: Business partner selector in Add Payment window fires the reload of the results in every change It has been added a check that only fires the reload of the data when the parameters change details: https://code.openbravo.com/erp/devel/pi/rev/0cf02944934f changeset: 13582:0cf02944934f user: Adrián Romero <adrianromero <at> openbravo.com> date: Tue Aug 23 14:27:58 2011 +0200 summary: Fixes issue 0018056: Business partner selector in Add Payment window fires the reload of the results in every change It has been added a check that only fires the reload of the data when the parameters change in the Payment Method drop down list diffstat: modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html | 62 ++++++++- modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js | 35 ++-- 2 files changed, 67 insertions(+), 30 deletions(-) diffs (134 lines): diff -r 1c281d64b1dc -r 0cf02944934f modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html Mon Aug 22 09:51:20 2011 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html Tue Aug 23 14:27:58 2011 +0200 @@ -52,6 +52,8 @@ OB.APRM.APFT_GLItems = []; OB.APRM.APFT_GLItemsId = 0; OB.APRM.HasGLItems = false; + OB.APRM.APFT_bp = null; + OB.APRM.APPM_bp = null; function callBackGrid(paramXMLParticular, XMLHttpRequestObj) { var strText = ''; if (getReadyStateHandler(XMLHttpRequestObj)) { @@ -87,13 +89,38 @@ } return true; } + function loadGridList() { - try { - var url = '../org.openbravo.advpaymentmngt.ad_actionbutton/AddPaymentFromTransaction.html'; - var paramXMLReq = null; - return submitXmlHttpRequest(callBackGrid, document.frmMain, 'GRIDLIST', url, false, null, paramXMLReq); - } catch (e) { - alert(e); + if (OB.APRM.APFT_bp === null || + OB.APRM.APFT_bp !== frmMain['inpcBpartnerId'].value || + OB.APRM.APFT_fa !== frmMain['inpFinancialAccountId'].value || + OB.APRM.APFT_ddf !== frmMain['inpDueDateFrom'].value || + OB.APRM.APFT_ddt !== frmMain['inpDueDateTo'].value || + OB.APRM.APFT_tdf !== frmMain['inpTransDateFrom'].value || + OB.APRM.APFT_tdt !== frmMain['inpTransDateTo'].value || + OB.APRM.APFT_dt !== frmMain['inpDocumentType'].value || + OB.APRM.APFT_cu !== frmMain['inpCurrencyId'].value || + OB.APRM.APFT_dn !== frmMain['inpDocumentNo'].value || + OB.APRM.APFT_re !== frmMain['isReceipt'].value) { + + OB.APRM.APFT_bp = frmMain['inpcBpartnerId'].value; + OB.APRM.APFT_fa = frmMain['inpFinancialAccountId'].value; + OB.APRM.APFT_ddf = frmMain['inpDueDateFrom'].value; + OB.APRM.APFT_ddt = frmMain['inpDueDateTo'].value; + OB.APRM.APFT_tdf = frmMain['inpTransDateFrom'].value; + OB.APRM.APFT_tdt = frmMain['inpTransDateTo'].value; + OB.APRM.APFT_dt = frmMain['inpDocumentType'].value; + OB.APRM.APFT_cu = frmMain['inpCurrencyId'].value; + OB.APRM.APFT_dn = frmMain['inpDocumentNo'].value; + OB.APRM.APFT_re = frmMain['isReceipt'].value; + + try { + var url = '../org.openbravo.advpaymentmngt.ad_actionbutton/AddPaymentFromTransaction.html'; + var paramXMLReq = null; + return submitXmlHttpRequest(callBackGrid, document.frmMain, 'GRIDLIST', url, false, null, paramXMLReq); + } catch (e) { + alert(e); + } } } function callBackPaymentMethod(paramXMLParticular, XMLHttpRequestObj) { @@ -111,12 +138,23 @@ } function loadPaymentMethodCombo() { - try { - var url = "../org.openbravo.advpaymentmngt.ad_actionbutton/AddPaymentFromTransaction.html"; - var paramXMLReq = null; - return submitXmlHttpRequest(callBackPaymentMethod, document.frmMain, "PAYMENTMETHODCOMBO", url, false, null, paramXMLReq); - } catch (e) { - alert(e); + + if (OB.APRM.APPM_bp === null || + OB.APRM.APPM_bp !== frmMain['inpcBpartnerId'].value || + OB.APRM.APPM_fa !== frmMain['inpFinancialAccountId'].value || + OB.APRM.APPM_re !== frmMain['isReceipt'].value) { + + OB.APRM.APPM_bp = frmMain['inpcBpartnerId'].value; + OB.APRM.APPM_fa = frmMain['inpFinancialAccountId'].value; + OB.APRM.APPM_re = frmMain['isReceipt'].value; + + try { + var url = "../org.openbravo.advpaymentmngt.ad_actionbutton/AddPaymentFromTransaction.html"; + var paramXMLReq = null; + return submitXmlHttpRequest(callBackPaymentMethod, document.frmMain, "PAYMENTMETHODCOMBO", url, false, null, paramXMLReq); + } catch (e) { + alert(e); + } } } diff -r 1c281d64b1dc -r 0cf02944934f modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js --- a/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js Mon Aug 22 09:51:20 2011 +0200 +++ b/modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-widget.js Tue Aug 23 14:27:58 2011 +0200 @@ -328,26 +328,25 @@ changeField(this.outFields[i].fieldName, ''); } } - return; - } + } else { + for (i in this.outFields) { + if (this.outFields.hasOwnProperty(i)) { + selectedObj[i] = selected[i]; + if (!this.outFields[i]) { + // skip id and _identifier and other columns without + // associated tab field + continue; + } - for (i in this.outFields) { - if (this.outFields.hasOwnProperty(i)) { - selectedObj[i] = selected[i]; - if (!this.outFields[i]) { - // skip id and _identifier and other columns without - // associated tab field - continue; + if (this.outFields[i].suffix) { + hiddenInput = this.outHiddenInputs[this.outHiddenInputPrefix + this.outFields[i].suffix]; + if (hiddenInput) { + hiddenInput.value = selected[i] ? selected[i] : ''; + } + } + + changeField(this.outFields[i].fieldName, selected[i]); } - - if (this.outFields[i].suffix) { - hiddenInput = this.outHiddenInputs[this.outHiddenInputPrefix + this.outFields[i].suffix]; - if (hiddenInput) { - hiddenInput.value = selected[i] ? selected[i] : ''; - } - } - - changeField(this.outFields[i].fieldName, selected[i]); } } ------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
