details: https://code.openbravo.com/erp/devel/pi/rev/1d81f1658178 changeset: 13751:1d81f1658178 user: Martin Taal <martin.taal <at> openbravo.com> date: Sun Sep 11 15:01:38 2011 +0200 summary: Related to issue 18470: Performance: generate smaller javascript for a window, improve view generation performance Solved wrong computation of length
details: https://code.openbravo.com/erp/devel/pi/rev/55112ce1d0c7 changeset: 13752:55112ce1d0c7 user: Martin Taal <martin.taal <at> openbravo.com> date: Sun Sep 11 21:51:31 2011 +0200 summary: Related to issue 18470: Performance: generate smaller javascript for a window, improve view generation performance Solved issue when saving order details: https://code.openbravo.com/erp/devel/pi/rev/a80dfdd3d362 changeset: 13753:a80dfdd3d362 user: Martin Taal <martin.taal <at> openbravo.com> date: Sun Sep 11 21:51:49 2011 +0200 summary: Merged Heads diffstat: modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js | 12 +++++---- modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js | 11 +++++++++ modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js | 2 +- src/org/openbravo/base/secureApp/HttpSecureAppServlet.java | 2 +- src/org/openbravo/base/secureApp/LoginHandler.java | 9 +++++- 5 files changed, 27 insertions(+), 9 deletions(-) diffs (104 lines): diff -r c0e7fedd7966 -r a80dfdd3d362 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js Sun Sep 11 14:55:11 2011 +0200 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js Sun Sep 11 21:51:49 2011 +0200 @@ -805,15 +805,19 @@ var assignClassicValue; var isDate, i, valueMap = {}, oldValue, field = this.getFieldFromColumnName(columnName), entries = columnValue.entries; // not a field on the form, probably a datasource field - var prop = this.view.getPropertyFromDBColumnName(columnName); + var propDef = this.view.getPropertyDefinitionFromDbColumnName(columnName); + var prop = propDef ? propDef.property : null; var id, identifier; if (!field) { - if (!prop) { + if (!propDef) { return; } field = this.getDataSource().getField(prop); if (!field) { - return; + field = { + name: propDef.property, + type: propDef.type + }; } } @@ -968,8 +972,6 @@ editValues[prop] = null; } - - // store the textualvalue so that it is correctly send back to the server if (field) { // Adjust to formatting if exists value and classicValue. diff -r c0e7fedd7966 -r a80dfdd3d362 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js Sun Sep 11 14:55:11 2011 +0200 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js Sun Sep 11 21:51:49 2011 +0200 @@ -1607,6 +1607,17 @@ return null; }, + getPropertyDefinitionFromDbColumnName: function(columnName){ + var length = this.propertyToColumns.length, i; + for (i = 0; i < length; i++) { + var propDef = this.propertyToColumns[i]; + if (propDef.dbColumn === columnName) { + return propDef; + } + } + return null; + }, + getPropertyFromDBColumnName: function(columnName){ var length = this.propertyToColumns.length, i; for (i = 0; i < length; i++) { diff -r c0e7fedd7966 -r a80dfdd3d362 modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js --- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js Sun Sep 11 14:55:11 2011 +0200 +++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js Sun Sep 11 21:51:49 2011 +0200 @@ -260,7 +260,7 @@ // as arguments, note that the function does not expect an array as this // did not seem to be supported by selenium getSCLocator : function() { - var index = 0, path = [], length; + var index = 0, path = [], length = arguments.length; for (; index < length; index++) { path[index] = arguments[index]; } diff -r c0e7fedd7966 -r a80dfdd3d362 src/org/openbravo/base/secureApp/HttpSecureAppServlet.java --- a/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java Sun Sep 11 14:55:11 2011 +0200 +++ b/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java Sun Sep 11 21:51:49 2011 +0200 @@ -145,7 +145,7 @@ try { m_AuthManager = new DefaultAuthenticationManager(this); } catch (AuthenticationException e1) { - log4j.error("Error trying to initilize Authentication Manager", e1); + log4j.error("Error trying to initialize Authentication Manager", e1); return; } } diff -r c0e7fedd7966 -r a80dfdd3d362 src/org/openbravo/base/secureApp/LoginHandler.java --- a/src/org/openbravo/base/secureApp/LoginHandler.java Sun Sep 11 14:55:11 2011 +0200 +++ b/src/org/openbravo/base/secureApp/LoginHandler.java Sun Sep 11 21:51:49 2011 +0200 @@ -91,13 +91,18 @@ AuthenticationManager authManager; String authClass = OBPropertiesProvider.getInstance().getOpenbravoProperties() .getProperty("authentication.class", DEFAULT_AUTH_CLASS); - + if (authClass == null || authClass.equals("")) { + // If not defined, load default + authClass = "org.openbravo.authentication.basic.DefaultAuthenticationManager"; + } try { authManager = (AuthenticationManager) OBClassLoader.getInstance().loadClass(authClass) .newInstance(); authManager.init(this); } catch (Exception e) { - log4j.error("Error trying to instantiate auth-manager class: " + e.getMessage(), e); + log4j + .error("Defined authentication manager cannot be loaded. Verify the 'authentication.class' entry in Openbravo.properties"); + authManager = new DefaultAuthenticationManager(this); } ------------------------------------------------------------------------------ Using storage to extend the benefits of virtualization and iSCSI Virtualization increases hardware utilization and delivers a new level of agility. Learn what those decisions are and how to modernize your storage and backup environments for virtualization. http://www.accelacomm.com/jaw/sfnl/114/51434361/ _______________________________________________ Openbravo-commits mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openbravo-commits
