details: https://code.openbravo.com/erp/devel/pi/rev/f64852985d96
changeset: 13824:f64852985d96
user: Mikel Irurita <mikel.irurita <at> openbravo.com>
date: Fri Sep 23 12:57:31 2011 +0200
summary: [APRM] Fixes issue 18595: Import Bank Statement process fails when
bpname simple quote
diffstat:
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ImportBankFile.java
| 2 +-
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
| 16 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
diffs (57 lines):
diff -r 8bed3d97fec0 -r f64852985d96
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ImportBankFile.java
---
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ImportBankFile.java
Fri Sep 23 07:43:45 2011 +0200
+++
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ImportBankFile.java
Fri Sep 23 12:57:31 2011 +0200
@@ -54,7 +54,7 @@
if (vars.commandIn("DEFAULT")) {
String strProcessId = vars.getStringParameter("inpProcessId");
String strWindow = vars.getStringParameter("inpwindowId");
- String strKey = vars.getStringParameter("Fin_Financial_Account_ID");
+ String strKey = vars.getStringParameter("inpfinFinancialAccountId");
String strTabId = vars.getStringParameter("inpTabId");
String strMessage = "";
diff -r 8bed3d97fec0 -r f64852985d96
modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
Fri Sep 23 07:43:45 2011 +0200
+++
b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
Fri Sep 23 12:57:31 2011 +0200
@@ -219,18 +219,17 @@
BusinessPartner matchBusinessPartnerByName(String partnername) {
final StringBuilder whereClause = new StringBuilder();
-
+ List<Object> parameters = new ArrayList<Object>();
OBContext.setAdminMode();
try {
-
whereClause.append(" as bsl ");
- whereClause.append(" where bsl." +
FIN_BankStatementLine.PROPERTY_BPARTNERNAME + " = '"
- + partnername + "'");
+ whereClause.append(" where bsl." +
FIN_BankStatementLine.PROPERTY_BPARTNERNAME + " = ?");
whereClause.append(" and bsl." +
FIN_BankStatementLine.PROPERTY_BUSINESSPARTNER
+ " is not null");
whereClause.append(" order by bsl." +
FIN_BankStatementLine.PROPERTY_CREATIONDATE + " desc");
+ parameters.add(partnername);
final OBQuery<FIN_BankStatementLine> bsl =
OBDal.getInstance().createQuery(
- FIN_BankStatementLine.class, whereClause.toString());
+ FIN_BankStatementLine.class, whereClause.toString(), parameters);
List<FIN_BankStatementLine> matchedLines = bsl.list();
if (matchedLines.size() == 0)
return null;
@@ -244,14 +243,15 @@
BusinessPartner finBPByName(String partnername) {
final StringBuilder whereClause = new StringBuilder();
+ List<Object> parameters = new ArrayList<Object>();
OBContext.setAdminMode();
try {
-
whereClause.append(" as bp ");
- whereClause.append(" where bp." + BusinessPartner.PROPERTY_NAME + " = '"
+ partnername + "'");
+ whereClause.append(" where bp." + BusinessPartner.PROPERTY_NAME + " =
?");
+ parameters.add(partnername);
final OBQuery<BusinessPartner> bp =
OBDal.getInstance().createQuery(BusinessPartner.class,
- whereClause.toString());
+ whereClause.toString(), parameters);
List<BusinessPartner> matchedBP = bp.list();
if (matchedBP.size() == 0)
return null;
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2dcopy2
_______________________________________________
Openbravo-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
