details: https://code.openbravo.com/erp/devel/pi/rev/d0483d32b533 changeset: 28870:d0483d32b533 user: Atul Gaware <atul.gaware <at> openbravo.com> date: Wed Apr 06 15:23:01 2016 +0530 summary: Fixes bug 32573:Not possible to execute Automatic Deposit payment created in FA
Before creating a record in financial account transaction, check is done: if transaction exists, get it so that no transactiom is created and the same is sent for processing details: https://code.openbravo.com/erp/devel/pi/rev/49bad45bc7c1 changeset: 28871:49bad45bc7c1 user: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> date: Mon Apr 11 11:02:52 2016 +0200 summary: Related to issue 32573: Update copyright diffstat: modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java | 17 ++++++++- 1 files changed, 14 insertions(+), 3 deletions(-) diffs (48 lines): diff -r 93df53b537f9 -r 49bad45bc7c1 modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java Mon Apr 11 10:46:58 2016 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_ExecutePayment.java Mon Apr 11 11:02:52 2016 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2010-2015 Openbravo SLU + * All portions are Copyright (C) 2010-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************* @@ -25,6 +25,7 @@ import java.util.Set; import org.apache.commons.lang.StringUtils; +import org.hibernate.criterion.Restrictions; import org.openbravo.advpaymentmngt.dao.AdvPaymentMngtDao; import org.openbravo.advpaymentmngt.dao.TransactionsDao; import org.openbravo.advpaymentmngt.exception.NoExecutionProcessFoundException; @@ -34,6 +35,7 @@ import org.openbravo.base.secureApp.VariablesSecureApp; import org.openbravo.client.kernel.RequestContext; import org.openbravo.dal.core.OBContext; +import org.openbravo.dal.service.OBCriteria; import org.openbravo.dal.service.OBDal; import org.openbravo.database.ConnectionProvider; import org.openbravo.erpCommon.utility.OBError; @@ -194,8 +196,17 @@ if (FIN_Utility.isAutomaticDepositWithdrawn(paymentRunPayment.getPayment()) && paymentRunPayment.getPayment().getAmount().compareTo(BigDecimal.ZERO) != 0 && !StringUtils.equals(internalParameters.get("comingFrom"), "TRANSACTION")) { - FIN_FinaccTransaction transaction = TransactionsDao - .createFinAccTransaction(paymentRunPayment.getPayment()); + OBCriteria<FIN_FinaccTransaction> finAccTransactionCriteria = OBDal + .getInstance().createCriteria(FIN_FinaccTransaction.class); + finAccTransactionCriteria.add(Restrictions.eq( + FIN_FinaccTransaction.PROPERTY_FINPAYMENT, payment)); + finAccTransactionCriteria.setMaxResults(1); + FIN_FinaccTransaction transaction = (FIN_FinaccTransaction) finAccTransactionCriteria + .uniqueResult(); + if (transaction == null) { + transaction = TransactionsDao.createFinAccTransaction(paymentRunPayment + .getPayment()); + } VariablesSecureApp vars = new VariablesSecureApp(RequestContext.get() .getRequest()); OBError processTransactionError = processTransaction(vars, ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
