details: https://code.openbravo.com/erp/devel/pi/rev/40651550f0f4 changeset: 29366:40651550f0f4 user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Apr 29 08:14:20 2016 +0200 summary: related to bug 32811: show log when exception in setting filter expression
details: https://code.openbravo.com/erp/devel/pi/rev/47ec70154e1f changeset: 29367:47ec70154e1f user: Asier Lostalé <asier.lostale <at> openbravo.com> date: Fri Apr 29 08:20:03 2016 +0200 summary: fixed bug 32811: "Payment Method" filter is not set automatically in Add Details When openeing Add Details process from Payment In window, Payment Method should be filtered by default according the method selected in the window. This filter was missing. The problem was due a refactor, now parameters are fixed at the begining of the method, this fix returns a new object instead of the original one, if new params are to be added, they need to be done in the new object rather than in the orginal one diffstat: modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpression.java | 3 ++- modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diffs (33 lines): diff -r e47bc61fb8bd -r 47ec70154e1f modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpression.java --- a/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpression.java Thu Apr 28 14:03:21 2016 +0200 +++ b/modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddOrderOrInvoiceFilterExpression.java Fri Apr 29 08:20:03 2016 +0200 @@ -11,7 +11,7 @@ * under the License. * The Original Code is Openbravo ERP. * The Initial Developer of the Original Code is Openbravo SLU - * All portions are Copyright (C) 2014 Openbravo SLU + * All portions are Copyright (C) 2014-2016 Openbravo SLU * All Rights Reserved. * Contributor(s): ______________________________________. ************************************************************************ @@ -59,6 +59,7 @@ } } } catch (Exception e) { + log.error("Error calculating filter expression", e); return ""; } return ""; diff -r e47bc61fb8bd -r 47ec70154e1f modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java --- a/modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java Thu Apr 28 14:03:21 2016 +0200 +++ b/modules/org.openbravo.client.application/src/org/openbravo/client/application/process/DefaultsProcessActionHandler.java Fri Apr 29 08:20:03 2016 +0200 @@ -103,7 +103,8 @@ if (field.getObuiappDefaultExpression() != null) { String rawDefaultExpression = field.getObuiappDefaultExpression(); Object defaultExpression; - parameters.put("filterExpressionColumnName", field.getColumn().getDBColumnName()); + fixedParameters.put("filterExpressionColumnName", field.getColumn() + .getDBColumnName()); defaultExpression = ParameterUtils.getJSExpressionResult(fixedParameters, (HttpSession) parameters.get(KernelConstants.HTTP_SESSION), rawDefaultExpression); ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Openbravo-commits mailing list Openbravo-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openbravo-commits
