On 07/25/2011 05:46 PM, Dennis Wehrle wrote: > Hi Holger >> I have moved the VTY change to a new patch (if you want to I can >> use you as author), > > I think, it's not necessary :)
hehe, we are picky, one change, one (atomic) reason. > I think there are some typos in my commit message. For instance, in the first > sentence, i think it should be 'were' instead of 'where'. Yes, and in general 72/80 chars per line limit. (also try to follow it in the code) > > Sure, i can split it up. My understanding is that the patch for task 2.) > depends on task 1.) and the patch for task 3.) depends on task 2.). (create a > patch between the commits) Right? exactly, it should be commits depending on each other. > Ok, i can work on the missing two parts. I will also have a look at your > patch. > thanks.
