On Wed, Mar 12, 2014 at 7:53 PM, Alexander Chemeris <[email protected]> wrote: > On Wed, Mar 12, 2014 at 6:59 PM, Daniel Willmann <[email protected]> > wrote: >> Hello Alexander, >> >> On Wed, 2014-03-12 at 01:44, Alexander Chemeris wrote: >>> I've updated the patch to rename gsm340_validity_period() to >>> gsm340_validity_period_2() and keep gsm340_validity_period() as a >>> deprecated broken implementation. This way we keep compatibility with >>> older OpenBSC versions without updating to a new libosmocore library. >> >> looks all fine except for the function name. Something more expressive >> would be nice - how about gsm340_validity_period_as_ts()? > > I'm not sure "as_ts" is really more expressive, > gsm340_validity_period_unix_time() would be more expressive, but it's > also painfully long. I would suggest: > - gsm340_validity_time() > - gsm340_validity_period_decode() > - leave as is
- gsm340_valid_until() -- Regards, Alexander Chemeris. CEO, Fairwaves, Inc. / ООО УмРадио https://fairwaves.co
