> On 21 Jul 2015, at 16:23, [email protected] wrote:
>
> From: Pablo Neira Ayuso <[email protected]>
>
> Add a new field to count the number of messages in the batch that are pending
> to be transformed to osmux. Use this new field to check when to enable the
> osmux timer.
okay, when one counts a list one needs to be careful to have it balanced. While
having a look if it is balanced I noticed this in the original code:
static struct msgb *osmux_build_batch(struct osmux_in_handle *h)
{
…
llist_for_each_entry_safe(node, tnode, &batch->node_list, head) {
struct msgb *cur, *tmp;
int ctr = 0;
llist_for_each_entry_safe(cur, tmp, &node->list, list) {
struct rtp_hdr *rtph;
int add_osmux_hdr = 0;
#ifdef DEBUG_MSG
...
#endif
rtph = osmo_rtp_get_hdr(cur);
if (rtph == NULL)
return NULL;
When and how will this package be dropped?
Patches 4-7 look good too!
