On Sat, Aug 08, 2015 at 09:11:39PM +0200, Holger Freyther wrote: > > > On 21 Jul 2015, at 16:23, [email protected] wrote: > > > > -AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) > > +AM_CFLAGS = -Wall -I$(top_srcdir)/include $(LIBOSMOCORE_CFLAGS) -g > > I like -ggdb3 :)
OK, will change this. > In terms of the tests. You run the code but I don’t see many asserts. Could > you > please explain how the “no voice traffic” code tests? Would a lack of data end > printing a message that would cause the test to fail? The test most likely will timeout if it doesn't get any voice traffic. But I think it's a good idea to add more asserts. In summary: 1) Will rename dummy to ndummy. 2) Will mangle this patch to replace -g to -ggdb3. And I will push out this patchset, then will send two follow up patches: 3) Will revisit the one timer running + circuit gone scenario. This will come in a follow up patch since this problem since to be there since the beginning. 4) Will add more asserts to validate osmux outputs from tests. Fine with this procedure? Let me know if I'm missing anything. Thanks for reviewing.
