> On 19 Feb 2016, at 19:17, [email protected] wrote:
>
>
good!
>
> +/*! \brief PH-DATA presence information */
> +enum osmo_ph_pres_info_type {
> + PRES_INFO_INVALID = 0, /*!< \brief Data is invalid */
> + PRES_INFO_HEADER = 1, /*!< \brief Only header is present and valid */
> + PRES_INFO_FIRST = 3, /*!< \brief First half of data + header are
> valid (2nd half may be present but invalid) */
> + PRES_INFO_SECOND = 5, /*!< \brief Second half of data + header are
> valid (1st halfmay be present but invalid) */
> + PRES_INFO_BOTH = 7, /*!< \brief Both parts + header are present and
> valid */
do you intend to use it as a bit mask or why the b101 and b111?
> + PRES_INFO_UNKNOWN
> +};
> +
> /*! \brief for PH-RANDOM_ACCESS.req */
> struct ph_rach_req_param {
>
> + enum osmo_ph_pres_info_type pdch_presence_info; /*!< \brief Info
> regarding presence/validity of header and data parts */
> };
This might or might not change the size of the struct osmo_phsap_prim and then
we have an ABI issue. For such cases we have created the TODO-RELEASE file to
indicate that we need to bump the SOVERSION on the next release.
holger
