Martin S. Tignor wrote: > > On Thu, 2003-09-04 at 23:31, Rob Lahaye wrote: > >>Argh, if you want to apply, please apply attached patch instead. >>I forgot the "int xu = 0;" in case of DXD_OS_NON_UNIX.... > > I'll take a look at it. > > In the mean time... > - Do you think you should add execute permission for group and > other? Ordinarily, files are 644 and directores are 755. > - Do you need execute permission for the directory > for the non unix case? In other words, is xu=0; what you really want?
I'm glad to hear you consider this patch. I really think it is much better this way. 1) My patch maintained as much of the original code as possible. I only discovered that I need the execution bit for the directory, otherwise the file creation fails (on my FreeBSD/Unix system at least). 2) The file creating in DX uses bits "rw-r--r--" (644), which is also the default umask on my FreeBSD/Unix system. However, the directory creating in DX uses now "rwxr--r--", whereas the mkdir command creates by default directories with "rwxr-xr-x" (755). You can change that, if you consider that to be better. 3) For non-Unix: I have not the slightest idea! I searched a bit the internet and found that there's no such thing as execution-bit on MS-Windows systems, so I made xu=0 for non-Unices. But what about Mac or OS/2? Do with that whatever you think is best. Regards, Rob.
