Re: [opendx-dev] [PATCH] delete of something allocated with new[]

[Marco Morandini]

David L Thompson wrote:

These have already been rolled into 4.3.2.

Perhaps I'm wrong (or the patch is simply wrong),
but I don't think so.

For example:

[EMAIL PROTECTED]:~/Programmi/dx/src/uipp/dxuilib> cvs diff -u -r HEAD MsgWin.C
Index: MsgWin.C
===================================================================
RCS file: /src/master/dx/src/uipp/dxuilib/MsgWin.C,v
retrieving revision 1.13
diff -u -r1.13 MsgWin.C
--- MsgWin.C    30 Sep 2003 17:41:48 -0000      1.13
+++ MsgWin.C    9 Dec 2003 17:47:35 -0000
@@ -584,7 +584,7 @@
        XmStringFree(nameString);
        XmStringFree(firstHalf);
        XmStringFree(text);
-       delete line;
+       delete[] line;

        XmListAddItemUnselected(this->list, s, 0);
        XmStringFree(s);
@@ -702,7 +702,7 @@
     SelectableLine *l;
     while( (l = (SelectableLine*)li.getNext()) )
     {
-       delete l->line;
+       delete[] l->line;
        delete l;
     }
     this->selectableLines.clear();
@@ -774,7 +774,7 @@
            fputc('\n', this->logFile);
        }
        items[i] = XmStringCreate(s, "normal");
-       delete s;
+       delete[] s;
     }

     XmListAddItems(this->list, items, nItems, 0);
@@ -788,7 +788,7 @@

     for (i = 0; i < nItems; ++i)
        XmStringFree(items[i]);
-    delete items;
+    delete[] items;

     this->batchedLines.clear();

@@ -814,7 +814,7 @@
     char *s;
     ListIterator li(this->batchedLines);
     for (int i = 0; i < nItems && (s = (char*)li.getNext()); ++i)
-       delete s;
+       delete[] s;
     this->batchedLines.clear();

     this->clearSelectableLines();
@@ -833,7 +833,7 @@
     if (file == NULL && this->logFile)
     {
        fclose(this->logFile);
-       delete this->logFileName;
+       delete[] this->logFileName;
        this->logFile = NULL;
        this->logFileName = NULL;
        this->logOption->setState(FALSE);
@@ -843,7 +843,7 @@
        if (this->logFile)
        {
            fclose(this->logFile);
-           delete this->logFileName;
+           delete[] this->logFileName;
        }
        this->logFile = fopen(file, "w");
        if (this->logFile == NULL)
@@ -1078,7 +1078,7 @@
            this->inst = inst;
        };
        ~EdInfo () {
-           if (this->nodeName) delete this->nodeName;
+           if (this->nodeName) delete[] this->nodeName;
        };
 };
 //
@@ -1132,7 +1132,7 @@
                "Yes", "No", NULL,
                XmDIALOG_FULL_APPLICATION_MODAL
            );
-           delete confMsg;
+           delete[] confMsg;
            questionPosted = TRUE;
        }
     }