Hi Jacek,
Thanks for taking time out from your busy schedule to
look at the patch. I was wondering why your posts were a bit less
lately. Thought you would be on christmas vacation and taking some
well deserved R & R :) but No! You were busy with other things :).
Thanks for the comments. I will definitely keep them in mind the next
time I make a patch.
Regards
Manu
On 1/4/07, Jacek Laskowski <[EMAIL PROTECTED]> wrote:
On 1/4/07, Manu George <[EMAIL PROTECTED]> wrote:
> Hi Alan,
> My apologies on the tabs. I will use spaces in future. Thanks
> for taking the timeout to review and commit the patch.
Just to add to what have already been said. When you sent the email
yesterday about your contribution, I decided to go for it and reviewed
it. I didn't mean to hold the commit so I had not assigned it to
myself. To be honest, I first thought it would not take me much time
to review it and commit afterwards. I was mistaken. After half an hour
while looking at the patch, I was so amazed by its exceptional
robustness and simplicity. Right after I went through the patch and
scratched my head a couple of times I made the decision to put it on
hold to test it out thoroughly later (I'm quite busy with daily job
projects and Warszawa JUG activity). I'm glad Alan stepped forward and
took care of it.
Thanks Manu and Alan! If the patch had used spaces not tabs and no
public (wide open) fields (concept introduced in the old OpenEJB days,
though) it would have been one of the best patches I was about to have
committed (it's a shameless attempt to find faults with the patch to
encourage you to improve the container. You seem to get hold of the
internals of OpenEJB3!)
Jacek
--
Jacek Laskowski
http://www.jaceklaskowski.pl
