On Jan 5, 2007, at 9:23 AM, Alan D. Cabrera wrote:
On Jan 4, 2007, at 10:57 PM, Manu George wrote:
On 1/4/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote:
We should add this check to the verifier. Also it would be helpful
to explicitly say in the exception message that only NotSupported
and
Required are allowed.
Ok but I am a bit hazy about how validation takes place. A pointer on
where to look or how validation is done will be nice :). Also it
would
be nice if we have a framework for exception handling where we can
give error codes in the exceptions and the messages will be picked up
from a property file or something like that. That way error message
changes won't need code changes
This touches on some questions that I have been meaning to ask.
How and where do we want to support i18n?
Lots of OpenEJB already uses a message catalog. I think the correct
question is when are we going to sweep the code base for non-message
catalog messages.
BTW we should be able to simplify the message catalog now that Java
has printf.
We throw a number of vanilla RuntimeExceptions. Should we not
build a few OpenEJB exceptions on top of these?
I agree that vanilla RuntimeExceptions are bad, but I think we should
be careful when replacing these. In general, I think we should favor
the standard Java exception classes like NullPointer,
IllegalArgument, and IllegalState. I hope we can avoid the coupling
that happened in Geronimo when we had lots of "common" exceptions in
the geronimo-common module.
-dain
