On Tue, Nov 9, 2021 at 7:28 PM Petr Nechaev <[email protected]> wrote:
> Hi All, > > I would also emit a (switchable on / off) warning for VAR_append and > VAR:append without a space when VAR contains spaces already i.e.: > > VAR = "opt1 opt2" > VAR:append = "opt3" --> warning > > VAR2 = "--I-have-super-long-custom-option-flag" > VAR2:append = "-and-short-also" --> NO warning > But this 2nd example is what might be difficult to spot and most likely needs the leading space as well, right? Especially when there is some override like VAR2:append:machine-foo:distro-foo = "-and-short-also" in some .bbappend somewhere else. and you spend a lot of time trying to find out why --I-have-super-long-custom-option-flag isn't respected in this one build for some specific machine and specific distro, until you check with bitbake-getvar to find "--I-have-super-long-custom-option-flag-and-short-also" being used. So this warning can cause bunch of false positives, won't be able to catch other true positives and probably just adds false sense of security - instead of people learning to use bitbake-getvar early to notice possible issues.
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1349): https://lists.openembedded.org/g/openembedded-architecture/message/1349 Mute This Topic: https://lists.openembedded.org/mt/86933270/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-architecture/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
