Done :) A very short wrap-up for those who don’t have a GitHub account: I proposed to add oelint-adv to meta-openembedded as part of the GitHub CI pipeline. I know that many find oelint-adv too strict. I had the same experience using it first. But diving deeper into it found out that it’s highly customisable.
We found a configuration set which I believe is a good starting point. It’s much more permissive than the basic configuration and basically errors just if important parts are e.g. missing. I would be happy if more people would give it a try and give their opinion on what should be an error and what should be a warning. Having a solid basic common ground with regard to what a decent recipe should look like would ease the review process as it would require less manual labor and thus would make development faster and give a clearer view of what recipes should look like. My personal take on this: I wish there was a proper set of clear linting rules when a started writing my first recipes not too long ago. And I’m sure I’m not the only one. Another more technical question to discuss once a set of rules is found: how could this be integrated into the established workflow? Looking forward hearing from the community. Marius > On 29. Jan 2022, at 13:49, Alexander Kanavin <[email protected]> wrote: > > Yes, except you aren't subscribed to the list, so your replies won't be seen > by everyone, and you won't get replies that aren't CCd directly to you. > Please take the trouble, and do embrace that awful outdated email concept :) > > Alex > > On Sat, 29 Jan 2022 at 13:42, Marius Kriegerowski > <[email protected] <mailto:[email protected]>> wrote: > Dear Alex, > > Richard was kind enough to forward my email. Thanks @Richard. I’m happy to > continue the discussion here. > > Best > Marius > > >> On 29. Jan 2022, at 13:40, Alexander Kanavin <[email protected] >> <mailto:[email protected]>> wrote: >> >> Marius, I know you want everyone to move to github and abandon email (seeing >> the previous thread), but asking everyone to go there for the 'discussion' >> won't get you far. >> >> Please write a proposal, send it here to oe-architecture list, and do >> include a plan for transparently adding the linter to the existing patch by >> email workflows that don't require anyone to open github links, ever. >> >> Thanks, >> Alex >> >> On Sat, 29 Jan 2022 at 09:33, Richard Purdie >> <[email protected] >> <mailto:[email protected]>> wrote: >> Sharing a copy of this to openembedded-architecture. >> >> Cheers, >> >> Richard >> >> >> >> ---------- Forwarded message ---------- >> From: Marius Kriegerowski <[email protected] >> <mailto:[email protected]>> >> To: [email protected] >> <mailto:[email protected]> >> Cc: >> Bcc: >> Date: Sat, 29 Jan 2022 02:39:27 +0100 >> Subject: [Automated-testing] RFC Linter in meta-openembedded >> Good morning everybody, >> >> We started a discussion about integrating a linter to meta-openembedded to >> ease the review process, provide direct feedback to contributors and >> increase consistency across recipes. I invite everybody to join the >> discussion. https://github.com/openembedded/meta-openembedded/pull/465 >> <https://github.com/openembedded/meta-openembedded/pull/465> >> >> Cheers >> Marius >> >> >> PS I’m not sure this is the right email list to address this but I felt >> linters and CI related matters are part of automated testing. Thus, if you >> know a more suitable list let me know or feel free to forward. >> >> >> >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#1446): https://lists.openembedded.org/g/openembedded-architecture/message/1446 Mute This Topic: https://lists.openembedded.org/mt/88763351/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-architecture/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
