On Thu, 2026-08-27 at 14:25 +0100, Paul Barker wrote:
> On Wed, 2026-08-19 at 08:22 +0200, Thomas Roos wrote:
> > An empty IMAGE_LINK_NAME left a bare ".vex.json" symlink in the deploy
> > directory. Skip the link, as image.bbclass and rootfs-postcommands do.
> > 
> > AI-Generated: Uses Claude Opus 5
> > Signed-off-by: Thomas Roos <[email protected]>
> > ---
> >  meta/classes/vex.bbclass | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/vex.bbclass b/meta/classes/vex.bbclass
> > index b3c2aca..eee3af6 100644
> > --- a/meta/classes/vex.bbclass
> > +++ b/meta/classes/vex.bbclass
> > @@ -204,7 +204,8 @@ python vex_write_rootfs_manifest () {
> >      with open(manifest_name, "w") as f:
> >          json.dump(json_data, f, indent=2)
> >  
> > -    update_symlinks(manifest_name, link_path)
> > +    if link_name:
> > +        update_symlinks(manifest_name, link_path)
> 
> Using link_name in the conditional and link_path in the function
> argument is confusing. Perhaps we should move the link_path assignment
> inside this conditional? It's not used anywhere else.
> 
>     if link_name:
>         link_path = os.path.join(deploy_dir, "%s.vex.json" % link_name)
>         update_symlinks(manifest_name, link_path)

Actually, ignore this, I'm going in the wrong direction here.... I'll
reply to the cover letter about the whole series.

Sorry for the noise!

-- 
Paul Barker

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#244493): 
https://lists.openembedded.org/g/openembedded-core/message/244493
Mute This Topic: https://lists.openembedded.org/mt/120826002/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to