On Wed, 2026-08-19 at 08:22 +0200, Thomas Roos wrote:
> v1 fixed the sbom-cve-check input path. Paul noted that 2a80840a4fe0
> ("sbom-cve-check: Fix breakage with empty IMAGE_LINK_NAME") had already
> touched this class, and that other classes make the same assumption. That
> commit guarded the export symlinks; the input path is separate and still
> built from IMAGE_NAME. Patch 1 now uses the shape Paul suggested, and
> patches 2-4 fix the other sites found by auditing meta/classes*,
> meta/lib/oe and meta/lib/oeqa.
>
> Read and write sites need opposite handling of an empty value: read sites
> fall back to IMAGE_NAME, write sites skip the link. A central default (pin
> IMAGE_LINK_NAME to IMAGE_NAME when empty) does not work, as create_symlinks
> and multiubi_mkfs have no link != target check and IMAGE_NAME is itself
> derived from IMAGE_LINK_NAME.
>
> Tested on qemux86-64, each fix confirmed in both directions. Patch 5 covers
> patches 2-4 in one build; patch 1 was checked by hand, as a selftest would
> need the sbom-cve-check databases (~8.7G of git).
>
> AI-Generated: Uses Claude Opus 5
Hi Thomas,
I discussed this with Richard, we want to avoid increasing the
complexity of the code unnecessarily.
IMAGE_LINK_NAME is intended to always be valid, we need the link because
IMAGE_NAME is dependent on the date and time that an image was built. Do
we really need to support the case where IMAGE_LINK_NAME is unset?
If we don't need to support IMAGE_LINK_NAME being unset then perhaps we
should just print a better error message in that case and give up.
Best regards,
--
Paul Barker
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#244500):
https://lists.openembedded.org/g/openembedded-core/message/244500
Mute This Topic: https://lists.openembedded.org/mt/120826000/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
