Op 16 jun 2011, om 15:44 heeft Khem Raj het volgende geschreven:
> On 6/16/2011 2:35 AM, Phil Blundell wrote:
>> On Thu, 2011-06-16 at 17:20 +0800, Dongxiao Xu wrote:
>>> Enable ofono plugin into sato image.
>>
>> [...]
>>
>>> --- a/meta/recipes-connectivity/connman/connman.inc
>>> +++ b/meta/recipes-connectivity/connman/connman.inc
>>> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>>>
>>> file://src/main.c;beginline=1;endline=20;md5=4b55b550fa6b33cc2055ef30dd262b3e"
>>>
>>> DEPENDS = "libgdbus dbus glib-2.0 hal iptables"
>>> -RDEPENDS_${PN} = "wpa-supplicant resolvconf"
>>> +RDEPENDS_${PN} = "wpa-supplicant resolvconf ofono"
>>
>>> --- a/meta/recipes-connectivity/connman/connman_0.65.bb
>>> +++ b/meta/recipes-connectivity/connman/connman_0.75.bb
>>> @@ -16,14 +16,14 @@ EXTRA_OECONF += "\
>>> --disable-udev \
>>> --disable-polkit \
>>> --enable-client \
>>> + --enable-ofono \
>>> --prefix=/usr --sysconfdir=/etc --localstatedir=/var"
>>
>> These changes look like they will have a rather wider impact than just
>> the sato image. I'm not sufficiently au fait with connman to say
>> whether this is a good thing or not (although my immediate reaction to
>> adding extra RDEPENDS tends to be that it is not), but if they're going
>> to be added globally then the checkin comment ought to reflect that and
>> explain why it's being done. Alternatively, you could do this in your
>> distro layer and/or image recipes.
>>
>
> I would say put ofono as a DISTRO_FEATURE
You don't need to build ofono to have ofono support in connman. Angstrom (and
hence meta-oe) build with it enabled by default to support people who want to
use the plugin on their phones. Since it's a nicely seperated plugin,
DISTRO_FEATURE would be the wrong thing to do.
That's why I keep saying "look at the connman recipe in meta-oe", that's being
used by angstrom and SHR with good success.
regards,
Koen
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
