> > > > On Thu, 2011-08-04 at 08:01 -0700, [email protected] wrote: > > > # ELF32 ABI > > > TUNEVALID[m32] = "IA32 ELF32 standard ABI" > > > -TUNECONFLICTS[m32] = "m64" > > > +TUNECONFLICTS[m32] = "m64 mx32" > > > TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m32", > > "${X86ARCH32}", "" ,d)}" > > > +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m32", > "32", > > "" ,d)}" > > > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m32", "- > m32", > > "", d)}" > > > > This is going to cause TARGET_OS to change for everyone using the > i586 > > ABI, right? That doesn't seem like it is either necessary or > > desirable, > > and it isn't mentioned in the checkin comment either. > > Correct, this will change the TARGET_OS from linux_gnu to linux_gnu32. > And it is also applicable for x86-64 machine set with x86 tune. This > change is be needed if multiple tunes are built from the same build > directory. If such situation is not important then the ABIEXTENSION > part can be dropped. > > > > > > # ELF64 ABI > > > TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI" > > > -TUNECONFLICT[m64] = "m32" > > > +TUNECONFLICT[m64] = "m32 mx32" > > > TUNE_ARCH .= "${@bb.utils.contains("TUNE_FEATURES", "m64", > > "${X86ARCH64}", "" ,d)}" > > > +ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "m64", > "64", > > "" ,d)}" > > > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "m64", "- > m64", > > "", d)}" > > > > ... and likewise this for anybody using the x86-64 ABI. > This is similar to above. > > > > > > -PACKAGE_EXTRA_ARCHS_tune-x86-64 = "x86_64" > > > +PACKAGE_EXTRA_ARCHS_tune-x86-64 = "x86-64" > > > > That change might well be fine, but again it isn't mentioned in the > > checkin message. > This is making this consistent with other PACKAGE_EXTRA_ARCHS_tune > convention elsewhere. I will update the commit message for this. > > > > > > diff --git a/meta/conf/machine/include/tune-x86_64.inc > > b/meta/conf/machine/include/tune-x86_64.inc > > > index 04b0f96..50f20ba 100644 > > > --- a/meta/conf/machine/include/tune-x86_64.inc > > > +++ b/meta/conf/machine/include/tune-x86_64.inc > > > @@ -1,3 +1,3 @@ > > > require conf/machine/include/ia32/arch-ia32.inc > > > > > > -DEFAULTTUNE = "x86-64" > > > +DEFAULTTUNE ?= "x86-64" > > > > This one is also not mentioned in the checkin message and looks a bit > > more dubious to me. Why is this required? > > > It was required at one point when multilist support was quiet unstable. > The reason it is done because the arch-ia32.inc file is included for > both x86, tune-core, & x86-64 and setting this hard assignment, was > breaking x86 or x32 targets. Not sure if it is still needed, I will > check it. Just checked, this is needed, when qemux86-64 machine is configured with x32 abi, when a different default tune is used. Nitin
> > > p. > > > > > > > > _______________________________________________ > > Openembedded-core mailing list > > [email protected] > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > _______________________________________________ > Openembedded-core mailing list > [email protected] > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
