On 11/27/2017 08:11 PM, Khem Raj wrote:
3) and the cool part: devtool will create a diff of the old and new
licenses,
and write the diff into the workspace recipe as a comment, like this:
adding a comment in recipe itself might start folks sending patches with
this text in the recipe changes. It should just be in commit message.
I'm not sure if this was clear, but the auto-generated license diff is
meant as a starting point for a commit summary written by a human, and
once the summary is written, should be deleted, regardless of whether it
was placed in a recipe, commit message or a separate file. Devtool does
not create or manage commits from the changes it makes to recipes, and
so placing this into the recipe felt the most appropriate to me
(separate files are more cumbersome to manage and printing to stdout can
be forgotten). We can have an automatic patch qa check that it's not
accidentally left over, similar to the existing check that license
changes have an explanation.
Alex
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
