I just tested this new behaviour and I for one like how it worked. It's sufficiently verbose that it obviously needs to be deleted and is stashed somewhere useful.
A new patchtest test to automatically tell people if they left it in the recipe would be good too. Ross On 29 November 2017 at 08:07, Alexander Kanavin < [email protected]> wrote: > On 11/29/2017 09:43 AM, Khem Raj wrote: > >> I'm not sure if this was clear, but the auto-generated license diff is >>> meant >>> as a starting point for a commit summary written by a human, and once the >>> summary is written, should be deleted, regardless of whether it was >>> placed >>> in a recipe, commit message or a separate file. Devtool does not create >>> or >>> manage commits from the changes it makes to recipes, and so placing this >>> into the recipe felt the most appropriate to me (separate files are more >>> cumbersome to manage and printing to stdout can be forgotten). We can >>> have >>> an automatic patch qa check that it's not accidentally left over, >>> similar to >>> the existing check that license changes have an explanation. >>> >> >> I think emitting this info to stdout should be enough. >> > > Between issuing 'devtool upgrade' and issuing 'git commit' with the > upgrade a lot of things can happen. Patches need to be rebased by hand, > build failures need to be dealt with, fixes need to be submitted upstream. > Oh, and the changes need to be tested on target sometimes. Between all > that, what the original command printed can be easily lost or forgottten. > Much better to stash it somewhere where it will be safe. > > Alex > > > -- > _______________________________________________ > Openembedded-core mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-core >
-- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
