On 01/25/2018 12:43 PM, Khem Raj wrote:
On 1/12/18 7:45 PM, Christopher Larson wrote:
On Fri, Jan 12, 2018 at 6:06 AM, Alex Stewart <alex.stew...@ni.com
<mailto:alex.stew...@ni.com>> wrote:

     * Move the hwclock.sh initscript from the busybox recipe to util-linux.
       This script is generally useful for distros that get their hwclock
       implementation from sources other than busybox and we follow debian's
       example by providing it in util-linux.

     :busybox/*
     * Remove the busybox-hwclock package, as it no longer has a purpose.
     * If busybox is configured to include hwclock, the busybox package will
       RDEPEND on util-linux-hwclock-init.

     :util-linux/*
     * Provide the hwclock.sh script in util-linux-hwclock-init, which can be
       pulled by any packages that depend on its functionality.
     * util-linux-hwclock RDEPENDS on util-linux-hwclock-init for its
       initscript.

     Signed-off-by: Alex Stewart <alex.stew...@ni.com
     <mailto:alex.stew...@ni.com>>
     Acked-by: Haris Okanovic <haris.okano...@ni.com
     <mailto:haris.okano...@ni.com>>
     Acked-by: Adrian Ratiu <adrian.ra...@ni.com
     <mailto:adrian.ra...@ni.com>>
     Acked-by: Ken Sharp <ken.sh...@ni.com <mailto:ken.sh...@ni.com>>
     Natinst-ReviewBoard-ID: 214983, 215755


Just a note that this will slow down the build for targets that wouldn’t
otherwise build the util-linux recipe.
there is initscripts recipes, perhaps thats a better place for this.

I guess that depends on our rationale for what belongs in `initscripts`. Other distros seem to assert that `initscripts` is a minimum set of scripts to bring up a system (especially a sysvinit system) and they generally don't include the equivalent of our `hwclock.sh`. Including it in `initscripts` for us would mean that embedded devices without an RTC (but which use initscripts) and which otherwise have no use for hwclock implementations either get a broken script or end up building a package that they can't use.

That being said, this patch is actually deprecated in favor of

[OE-core][PATCH] recipes-core: breakout hwclock.sh from busybox (18-01-23)

which moves hwclock.sh into it's own hwclock-init recipe and package, that is DEPENDED by busybox (conditionally, if built with hwclock capability) and util-linux. So further discussion should be attached to that patch. Sorry for the confusion.

--
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics


--
Alex Stewart
Software Engineer - LabVIEW Real-Time
National Instruments

alex.stew...@ni.com

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Reply via email to