On Mon, 2018-06-11 at 12:39 +0000, Devarsh Thakkar wrote: > Hi Richard, > > Thanks for the quick review. > Replies inline. > > > Message: 5 > > Date: Sun, 10 Jun 2018 09:29:14 +0100 > > From: Richard Purdie <richard.pur...@linuxfoundation.org> > > To: Devarsh Thakkar <devarsh.thak...@xilinx.com>, > > openembedded-core@lists.openembedded.org > > Cc: maul...@xilinx.com, varun...@xilinx.com, jae...@xilinx.com, > > Devarsh Thakkar <devar...@xilinx.com> > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID > > Message-ID: > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati > > on.org> > > Content-Type: text/plain; charset="UTF-8" > > > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote: > > > Pull in change which adds support for command line > > > options (-e and --command) which can be used for > > > launching programs or running commands in matchbox-terminal > > > via command line. > > > > > > Signed-off-by: Devarsh Thakkar <devar...@xilinx.com> > > > --- > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 > > > +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox- > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox- > > > terminal_0.1.bb > > > index 4488191..b7fbee7 100644 > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox- > > > terminal_0.1.bb > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox- > > > terminal_0.1.bb > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte" > > > SECTION = "x11/utils" > > > > > > #SRCREV tagged 0.1 > > > > I'm guessing the above comment is no longer valid, nor is the value > > of > > PV? > > Yes the comment is no longer valid I will remove that in V2. > But the PV is still valid as matchbox-terminal package version is > still 0.1 ( as set in AC_INIT at http://git.yoctoproject.org/cgit.cgi > /matchbox-terminal/tree/configure.ac) even after this commit.
No, after your change its not the 0.1 release, its 0.1+git<revision>, its a different version sometime after 0.1. Cheers, Richard -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core