Hi Richard, Ross > Message: 2 > Date: Mon, 11 Jun 2018 14:39:53 +0100 > From: Richard Purdie <[email protected]> > To: Devarsh Thakkar <[email protected]>, > "[email protected]" > <[email protected]> > Cc: Maulik Desai <[email protected]>, Varunkumar Allagadapa > <[email protected]> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID > Message-ID: > <642b938d82295e3b7ce922dad711c63904d62ca5.camel@linuxfounda > tion.org> > Content-Type: text/plain; charset="UTF-8" > > On Mon, 2018-06-11 at 12:39 +0000, Devarsh Thakkar wrote: > > Hi Richard, > > > > Thanks for the quick review. > > Replies inline. > > > > > Message: 5 > > > Date: Sun, 10 Jun 2018 09:29:14 +0100 > > > From: Richard Purdie <[email protected]> > > > To: Devarsh Thakkar <[email protected]>, > > > [email protected] > > > Cc: [email protected], [email protected], [email protected], > > > Devarsh Thakkar <[email protected]> > > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID > > > Message-ID: > > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati > > > on.org> > > > Content-Type: text/plain; charset="UTF-8" > > > > > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote: > > > > Pull in change which adds support for command line > > > > options (-e and --command) which can be used for > > > > launching programs or running commands in matchbox-terminal > > > > via command line. > > > > > > > > Signed-off-by: Devarsh Thakkar <[email protected]> > > > > --- > > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 > > > > +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox- > > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox- > > > > terminal_0.1.bb > > > > index 4488191..b7fbee7 100644 > > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox- > > > > terminal_0.1.bb > > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox- > > > > terminal_0.1.bb > > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte" > > > > SECTION = "x11/utils" > > > > > > > > #SRCREV tagged 0.1 > > > > > > I'm guessing the above comment is no longer valid, nor is the value > > > of > > > PV? > > > > Yes the comment is no longer valid I will remove that in V2. > > But the PV is still valid as matchbox-terminal package version is > > still 0.1 ( as set in AC_INIT at http://git.yoctoproject.org/cgit.cgi > > /matchbox-terminal/tree/configure.ac) even after this commit. > > No, after your change its not the 0.1 release, its 0.1+git<revision>, > its a different version sometime after 0.1. Thanks for sharing, I got your point. I guess there are below possible solutions here : 1) set PV="${BPV}+gitr${SRCPV}" were BPV=0.1 2) move the tag 0.1 to ccbc3c70946b04313c6166ab0dfef21e5e83c289 for matchbox-terminal 3) Update a new tag at 0.2 at to ccbc3c70946b04313c6166ab0dfef21e5e83c289
Kindly let me know which of the above is preferred way. Thanks, Devarsh > > Cheers, > > Richard > > > ------------------------------ > > Message: 3 > Date: Mon, 11 Jun 2018 12:39:20 +0000 > From: Devarsh Thakkar <[email protected]> > To: "[email protected]" > <[email protected]>, > "[email protected]" > <[email protected]> > Cc: Maulik Desai <[email protected]>, Varunkumar Allagadapa > <[email protected]> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID > Message-ID: > <[email protected] > amprd02.prod.outlook.com> > > Content-Type: text/plain; charset="us-ascii" > > Hi Richard, > > Thanks for the quick review. > Replies inline. > > > Message: 5 > > Date: Sun, 10 Jun 2018 09:29:14 +0100 > > From: Richard Purdie <[email protected]> > > To: Devarsh Thakkar <[email protected]>, > > [email protected] > > Cc: [email protected], [email protected], [email protected], > > Devarsh Thakkar <[email protected]> > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID > > Message-ID: > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati > > on.org> > > Content-Type: text/plain; charset="UTF-8" > > > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote: > > > Pull in change which adds support for command line > > > options (-e and --command) which can be used for > > > launching programs or running commands in matchbox-terminal > > > via command line. > > > > > > Signed-off-by: Devarsh Thakkar <[email protected]> > > > --- > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox- > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox- > > > terminal_0.1.bb > > > index 4488191..b7fbee7 100644 > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte" > > > SECTION = "x11/utils" > > > > > > #SRCREV tagged 0.1 > > > > I'm guessing the above comment is no longer valid, nor is the value of > > PV? > Yes the comment is no longer valid I will remove that in V2. > But the PV is still valid as matchbox-terminal package version is still 0.1 ( > as set > in AC_INIT at http://git.yoctoproject.org/cgit.cgi/matchbox- > terminal/tree/configure.ac) even after this commit. > > > > > > -SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f" > > > +SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289" > > > SRC_URI = "git://git.yoctoproject.org/${BPN}" > > > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))" > > > > > > > Cheers, > > > > Richard > > > Thanks, > Devarsh > > > ------------------------------ > > Message: 4 > Date: Mon, 11 Jun 2018 07:42:31 -0700 > From: akuster808 <[email protected]> > To: Peter Kjellerstedt <[email protected]>, > "[email protected]" > <[email protected]> > Subject: Re: [OE-core] [v5][PATCH] busybox: update to 1.28.4 > Message-ID: <[email protected]> > Content-Type: text/plain; charset=utf-8 > > > > On 06/11/2018 01:45 AM, Peter Kjellerstedt wrote: > >> -----Original Message----- > >> From: [email protected] > >> [mailto:[email protected]] On Behalf > Of > >> Armin Kuster > >> Sent: den 11 juni 2018 06:18 > >> To: [email protected]; [email protected] > >> Subject: [OE-core] [v5][PATCH] busybox: update to 1.28.4 > >> > >> refactored busybox-udhcpc-no_deconfig.patch for this update > >> updated 1.28.3 > >> > >> [v1] > >> removed patches included in update: > >> busybox/CVE-2011-5325.patch > >> busybox/CVE-2017-15873.patch > >> busybox/busybox-CVE-2017-16544.patch > >> > >> [v2] > >> Add back busybox-udhcpc-no_deconfig.patch ti SRC_URI, missed earlier > >> > >> [v3] > >> Update defconfig based on feedback > >> > >> [v4] > >> Decided to update again. > >> 1.28.4 > >> > >> [v5] > >> rebased change do to changes in master > >> squashed .cfg into defconfig and remove files > >> Delete busybox-fix-lzma-segfaults.patch which is included in updated. > >> > >> Signed-off-by: Armin Kuster <[email protected]> > > The commit message should be rewritten to document the final commit, > > without any patch series references. They belong after --- below. > > Done that before and folks complained so I started included with files > got removed. May I suggest updating the process so we can be consistent. > > - armin > > > >> --- > >> .../busybox/busybox/CVE-2011-5325.patch | 481 > >> --------------------- > >> .../busybox/busybox/CVE-2017-15873.patch | 95 ---- > >> .../busybox/busybox/busybox-CVE-2017-16544.patch | 43 -- > >> .../busybox/busybox-fix-lzma-segfaults.patch | 106 ----- > >> .../busybox/busybox-udhcpc-no_deconfig.patch | 36 +- > >> meta/recipes-core/busybox/busybox/defconfig | 278 ++++++------ > >> meta/recipes-core/busybox/busybox/getopts.cfg | 3 - > >> .../busybox/busybox/login-utilities.cfg | 13 - > >> meta/recipes-core/busybox/busybox/mdev.cfg | 2 - > >> .../busybox/busybox/mount-via-label.cfg | 9 - > >> meta/recipes-core/busybox/busybox/resize.cfg | 2 - > >> meta/recipes-core/busybox/busybox/sha1sum.cfg | 1 - > >> meta/recipes-core/busybox/busybox/sha256sum.cfg | 1 - > >> meta/recipes-core/busybox/busybox/syslog.cfg | 11 - > >> .../{busybox_1.27.2.bb => busybox_1.28.4.bb} | 15 +- > >> 15 files changed, 162 insertions(+), 934 deletions(-) > >> delete mode 100755 meta/recipes-core/busybox/busybox/CVE-2011- > 5325.patch > >> delete mode 100644 meta/recipes-core/busybox/busybox/CVE-2017- > 15873.patch > >> delete mode 100644 meta/recipes-core/busybox/busybox/busybox-CVE- > 2017-16544.patch > >> delete mode 100644 meta/recipes-core/busybox/busybox/busybox-fix- > lzma-segfaults.patch > >> delete mode 100644 meta/recipes-core/busybox/busybox/getopts.cfg > >> delete mode 100644 meta/recipes-core/busybox/busybox/login-utilities.cfg > >> delete mode 100644 meta/recipes-core/busybox/busybox/mount-via- > label.cfg > >> delete mode 100644 meta/recipes-core/busybox/busybox/resize.cfg > >> delete mode 100644 meta/recipes-core/busybox/busybox/sha1sum.cfg > >> delete mode 100644 meta/recipes-core/busybox/busybox/sha256sum.cfg > >> delete mode 100644 meta/recipes-core/busybox/busybox/syslog.cfg > >> rename meta/recipes-core/busybox/{busybox_1.27.2.bb => > busybox_1.28.4.bb} (72%) > > //Peter > > > > > > ------------------------------ > > -- > _______________________________________________ > Openembedded-core mailing list > [email protected] > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > End of Openembedded-core Digest, Vol 89, Issue 107 > ************************************************** -- _______________________________________________ Openembedded-core mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-core
