2018-07-12 16:54 keltezéssel, Burton, Ross írta:
I guess that tells us how many people actually use xcalibrate...
The breakage depends on whether you are using a repository to
upgrade your machines running Yocto or bring them in and reflash
with a new complete build.
But anyway, it's the maintainer's call. The previous patch itself
was an incompatible deviation from upstream and xinput_calibrator
is usually running locally, not remotely, so it's only an obscure
corner case.
On 12 July 2018 at 15:07, Böszörményi Zoltán via Openembedded-core
<openembedded-core@lists.openembedded.org> wrote:
Hi,
2018-04-04 03:49 keltezéssel, Armin Kuster írta:
From: Armin Kuster <akus...@mvista.com>
Signed-off-by: Armin Kuster <akus...@mvista.com>
---
.../xorg-proto/bigreqsproto_1.1.2.bb | 16 ---------
.../xorg-proto/calibrateproto/fix.patch | 42
----------------------
...
diff --git a/meta/recipes-graphics/xorg-proto/calibrateproto/fix.patch
b/meta/recipes-graphics/xorg-proto/calibrateproto/fix.patch
deleted file mode 100644
index ff8cb25..0000000
--- a/meta/recipes-graphics/xorg-proto/calibrateproto/fix.patch
+++ /dev/null
@@ -1,42 +0,0 @@
-Upstream-Status: Pending
-
-Add missing length fields to the replies. Without these, sanity checking
in recent X
-breaks things.
-
-RP 11/2/10
-
-
-Index: git/xcalibrateproto.h
-===================================================================
---- git.orig/xcalibrateproto.h 2010-02-11 11:47:45.711985932 +0000
-+++ git/xcalibrateproto.h 2010-02-11 11:40:21.000000000 +0000
-@@ -67,13 +67,13 @@
- BYTE type; /* X_Reply */
- BYTE pad1;
- CARD16 sequenceNumber B16;
-+ CARD32 length;
- CARD32 status;
- CARD32 pad2 B32;
- CARD32 pad3 B32;
- CARD32 pad4 B32;
- CARD32 pad5 B32;
- CARD32 pad6 B32;
-- CARD32 pad7 B32;
- } xXCalibrateRawModeReply;
-
- #define sz_xXCalibrateRawModeReply 32
-@@ -92,13 +92,13 @@
- BYTE type; /* X_Reply */
- BYTE pad1;
- CARD16 sequenceNumber B16;
-+ CARD32 length;
- CARD32 x;
- CARD32 y;
- CARD32 pad2 B32;
- CARD32 pad3 B32;
- CARD32 pad4 B32;
- CARD32 pad5 B32;
-- CARD32 pad6 B32;
- } xXCalibrateScreenToCoordReply;
-
- #define sz_xXCalibrateScreenToCoordReply 32
Haven't you just introduced an incompatible change by not adding the
identical
patch to [PATCH 17/21] xorgproto: add replacement for depricated
calibrateproto ?
Best regards,
Zoltán Böszörményi
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
