Richard, I'll consider more about maintenance issue next time.
Martin, thanks for taking care of this.
Best Regards,
Chen Qi
On 09/29/2018 08:55 PM, Martin Jansa wrote:
I'm refreshing the patch based on feedback from upstream, I'll
integrate the changes for ppc as well.
On Sat, Sep 29, 2018 at 2:26 PM Richard Purdie
<[email protected]
<mailto:[email protected]>> wrote:
On Sat, 2018-09-29 at 10:58 +0800, Chen Qi wrote:
> The patch 0031-sysdeps-ieee754-prevent-maybe-uninitialized-
> errors.patch
> did not take into consideration of qemuppc. Refresh it to also fix
> building for qemuppc.
>
> The related error message is like below:
>
> ../sysdeps/ieee754/ldbl-128ibm/e_jnl.c:153:20: error: 'temp'
may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Signed-off-by: Chen Qi <[email protected]
<mailto:[email protected]>>
> ---
> ...eee754-prevent-maybe-uninitialized-errors.patch | 41
> +++++++++++++++++-----
> 1 file changed, 32 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-
> prevent-maybe-uninitialized-errors.patch b/meta/recipes-
> core/glibc/glibc/0031-sysdeps-ieee754-prevent-maybe-uninitialized-
> errors.patch
> index b02c4ec..1c5b254 100644
> --- a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent-
> maybe-uninitialized-errors.patch
> +++ b/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent-
> maybe-uninitialized-errors.patch
> @@ -1,4 +1,4 @@
> -From c6cc5a6ef46837e341fe271b5ffa6def23810082 Mon Sep 17 00:00:00
> 2001
> +From 113241a738662854256c5e2e415397721b842862 Mon Sep 17 00:00:00
> 2001
> From: Martin Jansa <[email protected]
<mailto:[email protected]>>
> Date: Fri, 14 Sep 2018 23:23:03 +0000
> Subject: [PATCH] sysdeps/ieee754: prevent maybe-uninitialized
errors
> @@ -21,13 +21,14 @@ Upstream-Status: Submitted
[https://www.sourcewar
> e.org/ml/libc-alpha/2018-09/msg
<http://e.org/ml/libc-alpha/2018-09/msg>
I get nervous when we modify a patch submitted upstream. Was the patch
submitted accepted? Do we need to send this other piece upstream?
Cheers,
Richard
--
_______________________________________________
Openembedded-core mailing list
[email protected]
<mailto:[email protected]>
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
