Hi Ross,
On 6/20/19 9:56 PM, Burton, Ross wrote:
Why DEPENDS on gtk? The recipes will typically already do this, but
all this class needs is the rdepends. Also, there's no explanation
for the hicolor addition.
I got errors when running adwaita-icon-theme's postinst on target
(command gtk-update-icon-cache not found), the recipe doesn't depend
on gtk, and gtk-update-icon-cache is introduced by gtk-icon-cache.bbclass,
so I think that we should add this DEPENDS in the bbclass? If only add gtk
to RDEPENDS (no DEPENDS), there would be a warning like:
adwaita-icon-theme rdepends on gtk+3, but it isn't a build dependency?
For hicolor-icon-theme, it is an existed rdepends in gtk-icon-cache.bbclass,
so I left it there.
// Robert
Ross
On Thu, 20 Jun 2019 at 14:54, Richard Purdie
<[email protected]> wrote:
On Thu, 2019-06-20 at 17:58 +0800, Robert Yang wrote:
On 6/20/19 5:19 PM, Adrian Bunk wrote:
On Thu, Jun 20, 2019 at 04:46:16PM +0800, Robert Yang wrote:
...
Maybe gtk+2 is out of date? Since gtk+4 is on the way, so I think
that we
need something like virtual/gtk to fix these problems totally?
GTK+2 is mostly obsolete.
I just checked the GTK4 sources, and there it is renamed to
gtk4-update-icon-cache. Based on that I would say that your
patch is actually fine at least for now.
Thanks, I updated the commit message in the PULL:
Please resend patches rather than updating the branch as they get lost
really easily and also don't get reviewed properly this way.
Cheers,
Richard
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
