Agree. But I think that's the nature of DISTRO_FEATURES to be all or nothing. Also there's the infamous _remove that can be used to get rid of DISTRO_FEATURES based flags.
So what do you suggest to do here? Merge them or keep them separately? ------ Original message------ From: Richard Purdie Date: Wed, Jun 3, 2020 13:19 To: Konrad Weihmann;[email protected]; Cc: Subject:Re: [OE-core] [PATCH] ruby: properly append PACKAGECONFIG On Wed, 2020-06-03 at 13:03 +0200, Konrad Weihmann wrote: > Well I see a valid point in keeping them separated. > PACKAGECONFIG is just a static list of things, while the other > setting > is based on DISTRO_FEATURES. If we merge them, we kind force any > override from local or distro.conf to copy the DISTRO_FEATURES block > into their code or remove the DISTRO_FEATURES check - none of the > options is a good one IMHO. > With that in mind I personally would like to keep them separate and > just > fix the append. There are two sides to that, its also near impossible for the user to configure this option other than changing DISTRO_FEATURES if we use append, we can't win. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139167): https://lists.openembedded.org/g/openembedded-core/message/139167 Mute This Topic: https://lists.openembedded.org/mt/74636783/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
